Skip to content

Clean Code for bundles/org.eclipse.jface.text #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean Code for bundles/org.eclipse.jface.text #3293

wants to merge 1 commit into from

Conversation

eclipse-platform-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 2m 21s ⏱️ + 2m 45s
 8 019 tests ±0   7 774 ✅ +1  245 💤 ±0  0 ❌  - 1 
23 597 runs  ±0  22 815 ✅ +1  782 💤 ±0  0 ❌  - 1 

Results for commit 7ea3aa8. ± Comparison against base commit 27438b5.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 9 times, most recently from 41d9bee to 03683f1 Compare September 25, 2025 03:41
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 03683f1 to ab6b8d6 Compare September 26, 2025 03:28
@akurtakov
Copy link
Member

@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed?

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from ab6b8d6 to 88bee99 Compare September 27, 2025 03:25
@akurtakov akurtakov mentioned this pull request Sep 27, 2025
Merged
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 88bee99 to d1391ba Compare September 27, 2025 11:15
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 2 times, most recently from 45ed982 to 470f2f9 Compare September 30, 2025 03:30
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 470f2f9 to 7ea3aa8 Compare October 1, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov left review comments

+1 more reviewer

@jjohnstn jjohnstn jjohnstn left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eclipse-platform-bot @akurtakov @jjohnstn